TYP: NDFrame.(loc|iloc|at|iat) #30690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Jan 4, 2020
pandas/core/generic.py
Outdated
| @@ -3179,6 +3179,481 @@ def to_csv( | |||
| # ---------------------------------------------------------------------- | |||
| # Fancy Indexing | |||
|
|
|||
| @property | |||
There was a problem hiding this comment.
so to avoid moving these multiple times, can you create a mix-in class where these are put (you can define this in pandas.core.indexing i think would be ok), then just include it in the classes for Series/DataFrame
There was a problem hiding this comment.
maybe better (as we are going to do this anyhow) is create
pandas/core/generic/indexing.py (and put the mxin there)
There was a problem hiding this comment.
Good idea with a Mixin. Why do you want to set it on DataFrame/Series directly? Seems simpler to just set it on NDFrame.
jreback
added
Typing
topper-123
force-pushed
the
type_loc_iloc_at_iat
branch
from
7f8fe40 to
75ee396
Compare
jbrockmendel
reviewed
Jan 4, 2020
topper-123
force-pushed
the
type_loc_iloc_at_iat
branch
from
15f337b to
a6f7730
Compare
topper-123
force-pushed
the
type_loc_iloc_at_iat
branch
from
a6f7730 to
eda2ca6
Compare
|
thanks @topper-123 very nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the NDFrame indexers (.loc/.iloc/.at/.iat) are too complex set up to let mypy understand them. This PR makes their implementations understandable for mypy (and humans also maybe, the old imp. was a bit indirect so took som effort to understand).
One issue is that I - for the life of me - can't programatically set doc strings of properties and make mypy understand the properties' types at the same time. Python/mypy seem to demand that doc strings be set directly on the property if the type is to be understandable by mypy. E.g. Appender on a property is not supported by mypy. So I've set the doc string on the NDFrame properties, and reference them from the indexer classes instances. This makes the PR seem large, but it's mostly just moving the doc strings.